netdev - Re: [PATCH iproute2 v3 0/2] bpf: memory access fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8559907b-7a39-b719-f8bd-c7851e669372@mojatatu.com>
Date:   Tue, 26 May 2020 08:27:12 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Andrea Claudi <aclaudi@...hat.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-netdev <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>, asmadeus@...ewreck.org
Subject: Re: [PATCH iproute2 v3 0/2] bpf: memory access fixes

On 2020-05-25 4:53 a.m., Andrea Claudi wrote:


> 
> Reverting c0325b06382c will for sure fix the segfault identified by
> Jamal and get rid of the problems highlighted by Daniel and others.
> To fix the s[n]printf truncation warning we can simply check for its
> return value. From the snprintf man page:
> 
> "a return value of size or more means that the output was truncated."
> (caveat: until glibc 2.0.6 ret value for truncation is -1)
> 
> Jamal: if this works for you, I can submit an alternative to this
> patch series doing what I proposed above. What do you think?
> 

I am ok with that approach.

cheers,
jamal