lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 May 2020 18:13:17 -0700 (PDT) From: David Miller <davem@...emloft.net> To: fugang.duan@....com Cc: peppe.cavallaro@...com, alexandre.torgue@...com, joabreu@...opsys.com, kuba@...nel.org, netdev@...r.kernel.org, mcoquelin.stm32@...il.com, p.zabel@...gutronix.de, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH net 1/2] net: ethernet: dwmac: add Ethernet glue logic for NXP imx8 chip From: Fugang Duan <fugang.duan@....com> Date: Mon, 25 May 2020 18:29:13 +0800 > +static int imx_dwmac_init(struct platform_device *pdev, void *priv) > +{ > + struct imx_priv_data *dwmac = priv; > + struct plat_stmmacenet_data *plat_dat = dwmac->plat_dat; > + int ret; > + Please code these sequences as: struct plat_stmmacenet_data *plat_dat; struct imx_priv_data *dwmac = priv; int ret; plat_dat = dwmac->plat_dat; In order to have reverse christmas three local variable ordering. THank you.
Powered by blists - more mailing lists