netdev - Re: [greybus-dev] [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops

Open Source and information security mailing list archives

Date:   Tue, 26 May 2020 11:48:12 -0500
From:   Alex Elder <elder@...aro.org>
To:     Krzysztof Wilczyński <kw@...ux.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>, linux-pci@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Pavel Machek <pavel@....cz>, linux-s390@...r.kernel.org,
        linux-scsi@...r.kernel.org, Kevin Hilman <khilman@...nel.org>,
        Julian Wiedmann <jwi@...ux.ibm.com>,
        linux-acpi@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Len Brown <lenb@...nel.org>, linux-pm@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Ursula Braun <ubraun@...ux.ibm.com>,
        Johan Hovold <johan@...nel.org>, greybus-dev@...ts.linaro.org,
        John Stultz <john.stultz@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Felipe Balbi <balbi@...nel.org>, Alex Elder <elder@...nel.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Karsten Graul <kgraul@...ux.ibm.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [greybus-dev] [PATCH 8/8] net/iucv: Use the new device_to_pm()
 helper to access struct dev_pm_ops

On 5/26/20 10:07 AM, Krzysztof Wilczyński wrote:
> Hello Greg,
> 
> [...]
>> It's "interesting" how using your new helper doesn't actually make the
>> code smaller.  Perhaps it isn't a good helper function?

Helper functions often improve code readability, which is
beneficial even if it doesn't reduce code size or efficiency.

But I won't argue for or against this particular change.
It's OK with me either way.

					-Alex

> The idea for the helper was inspired by the comment Dan made to Bjorn
> about Bjorn's change, as per:
> 
>    https://lore.kernel.org/driverdev-devel/20191016135002.GA24678@kadam/
> 
> It looked like a good idea to try to reduce the following:
> 
>    dev->driver && dev->driver->pm && dev->driver->pm->prepare
> 
> Into something more succinct.  Albeit, given the feedback from yourself
> and Rafael, I gather that this helper is not really a good addition.
> 
> Thank you everyone and sorry for the commotion!
> 
> Krzysztof
> _______________________________________________
> greybus-dev mailing list
> greybus-dev@...ts.linaro.org
> https://lists.linaro.org/mailman/listinfo/greybus-dev
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives