lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 26 May 2020 11:48:12 -0500
From:   Alex Elder <>
To:     Krzysztof Wilczyński <>,
        Greg Kroah-Hartman <>
Cc:     Ulf Hansson <>,,
        Bjorn Andersson <>,
        Pavel Machek <>,,, Kevin Hilman <>,
        Julian Wiedmann <>,, Jakub Kicinski <>,
        Dan Carpenter <>,
        Len Brown <>,,
        "James E.J. Bottomley" <>,
        Ursula Braun <>,
        Johan Hovold <>,,
        John Stultz <>,
        Bjorn Helgaas <>,
        Felipe Balbi <>, Alex Elder <>,
        "Martin K. Petersen" <>,,,
        "Rafael J. Wysocki" <>,
        Karsten Graul <>,
        "David S. Miller" <>
Subject: Re: [greybus-dev] [PATCH 8/8] net/iucv: Use the new device_to_pm()
 helper to access struct dev_pm_ops

On 5/26/20 10:07 AM, Krzysztof Wilczyński wrote:
> Hello Greg,
> [...]
>> It's "interesting" how using your new helper doesn't actually make the
>> code smaller.  Perhaps it isn't a good helper function?

Helper functions often improve code readability, which is
beneficial even if it doesn't reduce code size or efficiency.

But I won't argue for or against this particular change.
It's OK with me either way.


> The idea for the helper was inspired by the comment Dan made to Bjorn
> about Bjorn's change, as per:
> It looked like a good idea to try to reduce the following:
>    dev->driver && dev->driver->pm && dev->driver->pm->prepare
> Into something more succinct.  Albeit, given the feedback from yourself
> and Rafael, I gather that this helper is not really a good addition.
> Thank you everyone and sorry for the commotion!
> Krzysztof
> _______________________________________________
> greybus-dev mailing list

Powered by blists - more mailing lists