netdev - Re: [PATCH bpf-next v2] libbpf: add API to consume the perf ring buffer content

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYyzQdukdACKaNHKuaZyFE4Qd2u0fJsUEV_hA_vhuSz4w@mail.gmail.com>
Date:   Tue, 26 May 2020 10:42:51 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Eelco Chaudron <echaudro@...hat.com>
Cc:     bpf <bpf@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH bpf-next v2] libbpf: add API to consume the perf ring
 buffer content

On Tue, May 26, 2020 at 2:22 AM Eelco Chaudron <echaudro@...hat.com> wrote:
>
> This new API, perf_buffer__consume, can be used as follows:
> - When you have a perf ring where wakeup_events is higher than 1,
>   and you have remaining data in the rings you would like to pull
>   out on exit (or maybe based on a timeout).
> - For low latency cases where you burn a CPU that constantly polls
>   the queues.
>
> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
> ---

Looks good, thanks. I'd really appreciate if you could follow up with
a fix to perf_buffer__free() as well. If not, I will get to it
eventually anyway :)

Acked-by: Andrii Nakryiko <andriin@...com>

[...]