netdev - Re: [bpf-next PATCH v5 5/5] bpf, selftests: test probe_* helpers from SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbOgrAmvq=G=w54A1xZFoSH=dRHMMDMJgeFo46bA=nBNw@mail.gmail.com>
Date:   Tue, 26 May 2020 11:09:14 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Yonghong Song <yhs@...com>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [bpf-next PATCH v5 5/5] bpf, selftests: test probe_* helpers from SCHED_CLS

On Sun, May 24, 2020 at 9:52 AM John Fastabend <john.fastabend@...il.com> wrote:
>
> Lets test using probe* in SCHED_CLS network programs as well just
> to be sure these keep working. Its cheap to add the extra test
> and provides a second context to test outside of sk_msg after
> we generalized probe* helpers to all networking types.
>
> Acked-by: Yonghong Song <yhs@...com>
> Signed-off-by: John Fastabend <john.fastabend@...il.com>
> ---

One day we need to just replace all bpf_prog_load() calls with
bpf_object__open() or skeleton open/load. But not today :)

Acked-by: Andrii Nakryiko <andriin@...com>

>  .../testing/selftests/bpf/prog_tests/skb_helpers.c |   30 ++++++++++++++++++++
>  .../testing/selftests/bpf/progs/test_skb_helpers.c |   28 +++++++++++++++++++
>  2 files changed, 58 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/skb_helpers.c
>  create mode 100644 tools/testing/selftests/bpf/progs/test_skb_helpers.c
>

[...]