netdev - Re: [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and change callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200526113207.31d1bec6@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 26 May 2020 11:32:07 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Petr Machata <petrm@...lanox.com>
Cc:     netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>,
        jhs@...atatu.com, jiri@...lanox.com, idosch@...lanox.com
Subject: Re: [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and
 change callbacks

On Tue, 26 May 2020 20:10:06 +0300 Petr Machata wrote:
> +static int red_change(struct Qdisc *sch, struct nlattr *opt,
> +		      struct netlink_ext_ack *extack)
> +{
> +	struct red_sched_data *q = qdisc_priv(sch);

net/sched/sch_red.c: In function red_change:
net/sched/sch_red.c:337:25: warning: unused variable q [-Wunused-variable]
  337 |  struct red_sched_data *q = qdisc_priv(sch);
      |                         ^

Needs to go to the next patch.

> +	struct nlattr *tb[TCA_RED_MAX + 1];
> +	int err;
> +
> +	if (!opt)
> +		return -EINVAL;
> +
> +	err = nla_parse_nested_deprecated(tb, TCA_RED_MAX, opt, red_policy,
> +					  extack);
> +	if (err < 0)
> +		return err;
> +
> +	return __red_change(sch, tb, extack);
>  }