netdev - Re: [iproute2 PATCH 0/2] Fix segfault in lib/bpf.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bd0af64-678f-0b71-821e-07044c9905dc@iogearbox.net>
Date:   Tue, 26 May 2020 23:27:39 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrea Claudi <aclaudi@...hat.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, dsahern@...il.com, jhs@...atatu.com
Subject: Re: [iproute2 PATCH 0/2] Fix segfault in lib/bpf.c

On 5/26/20 6:04 PM, Andrea Claudi wrote:
> Jamal reported a segfault in bpf_make_custom_path() when custom pinning is
> used. This is caused by commit c0325b06382cb ("bpf: replace snprintf with
> asprintf when dealing with long buffers").
> 
> As the only goal of that commit is to get rid of a truncation warning when
> compiling lib/bpf.c, revert it and fix the warning checking for snprintf
> return value
> 
> Andrea Claudi (2):
>    Revert "bpf: replace snprintf with asprintf when dealing with long
>      buffers"
>    bpf: Fixes a snprintf truncation warning
> 
>   lib/bpf.c | 155 +++++++++++++++---------------------------------------
>   1 file changed, 41 insertions(+), 114 deletions(-)
> 

Thanks for following up, Andrea! For the two:

Acked-by: Daniel Borkmann <daniel@...earbox.net>