netdev - Re: [PATCH net-next] tcp: tcp_v4_err() icmp skb is named icmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 15:13:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, maze@...gle.com
Subject: Re: [PATCH net-next] tcp: tcp_v4_err() icmp skb is named icmp_skb

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 25 May 2020 20:15:24 -0700

> I missed the fact that tcp_v4_err() differs from tcp_v6_err().
> 
> After commit 4d1a2d9ec1c1 ("Rename skb to icmp_skb in tcp_v4_err()")
> the skb argument has been renamed to icmp_skb only in one function.
> 
> I will in a future patch reconciliate these functions to avoid
> this kind of confusion.
> 
> Fixes: 45af29ca761c ("tcp: allow traceroute -Mtcp for unpriv users")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.