netdev - Re: [PATCH net-next] ipv4: potential underflow in compat_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 May 2020 17:53:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     viro@...iv.linux.org.uk, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, kuba@...nel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] ipv4: potential underflow in
 compat_ip_setsockopt()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Sat, 23 May 2020 20:46:48 +0300

> The value of "n" is capped at 0x1ffffff but it checked for negative
> values.  I don't think this causes a problem but I'm not certain and
> it's harmless to prevent it.
> 
> Fixes: 2e04172875c9 ("ipv4: do compat setsockopt for MCAST_MSFILTER directly")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.