lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 May 2020 12:35:55 +0200 From: "Rafael J. Wysocki" <rafael@...nel.org> To: Pavel Machek <pavel@...x.de> Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>, Dan Carpenter <dan.carpenter@...cle.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <lenb@...nel.org>, Kevin Hilman <khilman@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, Felipe Balbi <balbi@...nel.org>, Julian Wiedmann <jwi@...ux.ibm.com>, Karsten Graul <kgraul@...ux.ibm.com>, Ursula Braun <ubraun@...ux.ibm.com>, Jakub Kicinski <kuba@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, John Stultz <john.stultz@...aro.org>, "David S. Miller" <davem@...emloft.net>, greybus-dev@...ts.linaro.org, netdev <netdev@...r.kernel.org>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, Linux PCI <linux-pci@...r.kernel.org>, Linux PM <linux-pm@...r.kernel.org>, linux-s390@...r.kernel.org, "open list:TARGET SUBSYSTEM" <linux-scsi@...r.kernel.org>, "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" <linux-usb@...r.kernel.org> Subject: Re: [PATCH 2/8] ACPI: PM: Use the new device_to_pm() helper to access struct dev_pm_ops On Tue, May 26, 2020 at 11:45 AM Pavel Machek <pavel@...x.de> wrote: > > On Tue 2020-05-26 10:37:36, Rafael J. Wysocki wrote: > > On Mon, May 25, 2020 at 8:26 PM Krzysztof Wilczyński <kw@...ux.com> wrote: > > > > > > Use the new device_to_pm() helper to access Power Management callbacs > > > (struct dev_pm_ops) for a particular device (struct device_driver). > > > > > > No functional change intended. > > > > > > Signed-off-by: Krzysztof Wilczyński <kw@...ux.com> > > > --- > > > drivers/acpi/device_pm.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c > > > index 5832bc10aca8..b98a32c48fbe 100644 > > > --- a/drivers/acpi/device_pm.c > > > +++ b/drivers/acpi/device_pm.c > > > @@ -1022,9 +1022,10 @@ static bool acpi_dev_needs_resume(struct device *dev, struct acpi_device *adev) > > > int acpi_subsys_prepare(struct device *dev) > > > { > > > struct acpi_device *adev = ACPI_COMPANION(dev); > > > + const struct dev_pm_ops *pm = driver_to_pm(dev->driver); > > > > I don't really see a reason for this change. > > > > What's wrong with the check below? > > Duplicated code. Yes, compiler can sort it out, but... new version > looks better to me. So the new code would not be duplicated? Look at the other patches in the series then. :-)
Powered by blists - more mailing lists