netdev - Re: [PATCH v3 net-next] ne2k-pci: Fix various coding-style issues and improve printk() usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200526.231952.313275088392613610.davem@davemloft.net>
Date:   Tue, 26 May 2020 23:19:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     W_Armin@....de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next] ne2k-pci: Fix various coding-style issues
 and improve printk() usage

From: Armin Wolf <W_Armin@....de>
Date: Tue, 26 May 2020 20:03:02 +0200

> Fixed a ton of minor checkpatch errors/warnings and remove version
> printing at module init/when device is found and use MODULE_VERSION
> instead. Also modifying the RTL8029 PCI string to include the compatible
> RTL8029AS nic.
> The only mayor issue remaining is the missing SPDX tag, but since the
> exact version of the GPL is not stated anywhere inside the file, its
> impossible to add such a tag at the moment.
> But maybe it is possible, since 8390.h states Donald Becker's 8390
> drivers are licensed under GPL 2.2 only (= GPL-2.0-only ?).
> The kernel module containing this patch compiles and runs without
> problems on a RTL8029AS-based NE2000 clone card with kernel 5.7.0-rc6.
> 
> Signed-off-by: Armin Wolf <W_Armin@....de>

Applied, thank you.