netdev - Re: [PATCH] [net-next] nexthop: fix enum type confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3722aa2b-667d-eef2-b901-ef0ae943f8f2@gmail.com>
Date:   Wed, 27 May 2020 07:50:09 -0600
From:   David Ahern <dsahern@...il.com>
To:     Arnd Bergmann <arnd@...db.de>, David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     Colin Ian King <colin.king@...onical.com>,
        Stephen Worley <sworley@...ulusnetworks.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] [net-next] nexthop: fix enum type confusion

On 5/27/20 7:47 AM, Arnd Bergmann wrote:
> Clang points out a mismatch between function arguments
> using a different enum type:
> 
> net/ipv4/nexthop.c:841:30: error: implicit conversion from enumeration type 'enum nexthop_event_type' to different enumeration type 'enum fib_event_type' [-Werror,-Wenum-conversion]
>         call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
>         ~~~~~~~~~~~~~~~~~~~~~~      ^~~~~~~~~~~~~~~~~
> 
> This looks like a copy-paste error, so just use the intended
> type instead.
> 
> Fixes: 8590ceedb701 ("nexthop: add support for notifiers")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  net/ipv4/nexthop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Nate sent a fix a few hours ago:
https://lore.kernel.org/netdev/20200527080019.3489332-1-natechancellor@gmail.com/T/#u