netdev - Re: [PATCH 2/9] RDMA/mlx4: remove FMR support for memory registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200527140308.GG349682@unreal>
Date:   Wed, 27 May 2020 17:03:08 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Max Gurtovoy <maxg@...lanox.com>
Cc:     jgg@...lanox.com, dledford@...hat.com, galpress@...zon.com,
        dennis.dalessandro@...el.com, netdev@...r.kernel.org,
        sagi@...mberg.me, linux-rdma@...r.kernel.org, bvanassche@....org,
        santosh.shilimkar@...cle.com, tom@...pey.com,
        aron.silverton@...cle.com, israelr@...lanox.com, oren@...lanox.com,
        shlomin@...lanox.com, vladimirk@...lanox.com
Subject: Re: [PATCH 2/9] RDMA/mlx4: remove FMR support for memory registration

On Wed, May 27, 2020 at 12:46:27PM +0300, Max Gurtovoy wrote:
> HCA's that are driven by mlx4 driver support FRWR method to register
> memory. Remove the ancient and unsafe FMR method.
>
> Signed-off-by: Max Gurtovoy <maxg@...lanox.com>
> ---
>  drivers/infiniband/hw/mlx4/main.c       |  10 --
>  drivers/infiniband/hw/mlx4/mlx4_ib.h    |  16 ---
>  drivers/infiniband/hw/mlx4/mr.c         |  93 ----------------
>  drivers/net/ethernet/mellanox/mlx4/mr.c | 183 --------------------------------
>  include/linux/mlx4/device.h             |  21 +---
>  5 files changed, 2 insertions(+), 321 deletions(-)

I don't see this line removed and all "max_fmr_maps" related.
➜  kernel git:(rdma-next) git grep fmr drivers/infiniband/hw/mlx4/ | head -1
drivers/infiniband/hw/mlx4/main.c: props->max_map_per_fmr = dev->dev->caps.max_fmr_maps;

Thanks