netdev - Re: [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and change callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87367lv1ux.fsf@mellanox.com>
Date:   Wed, 27 May 2020 17:23:02 +0200
From:   Petr Machata <petrm@...lanox.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>,
        jhs@...atatu.com, jiri@...lanox.com, idosch@...lanox.com
Subject: Re: [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and change callbacks


Jakub Kicinski <kuba@...nel.org> writes:

> On Tue, 26 May 2020 20:10:06 +0300 Petr Machata wrote:
>> +static int red_change(struct Qdisc *sch, struct nlattr *opt,
>> +		      struct netlink_ext_ack *extack)
>> +{
>> +	struct red_sched_data *q = qdisc_priv(sch);
>
> net/sched/sch_red.c: In function red_change:
> net/sched/sch_red.c:337:25: warning: unused variable q [-Wunused-variable]
>   337 |  struct red_sched_data *q = qdisc_priv(sch);
>       |                         ^
>
> Needs to go to the next patch.

Indeed. I neglected to do my usual "git rebase -x" dance :-/