[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7abd5391-8668-bb45-0ca2-883e949620a9@gmail.com>
Date: Wed, 27 May 2020 09:50:43 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net
Cc: andrew@...n.ch, vivien.didelot@...il.com,
rmk+kernel@...linux.org.uk, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: felix: accept VLAN config regardless
of bridge VLAN awareness state
On 5/27/2020 9:45 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
>
> The ocelot core library is written with the idea in mind that the VLAN
> table is populated by the bridge. Otherwise, not even a sane default
> pvid is provided: in standalone mode, the default pvid is 0, and the
> core expects the bridge layer to change it to 1.
>
> So without this patch, the VLAN table is completely empty at the end of
> the commands below, and traffic is broken as a result:
>
> ip link add dev br0 type bridge vlan_filtering 0 && ip link set dev br0 up
> for eth in $(ls /sys/bus/pci/devices/0000\:00\:00.5/net/); do
> ip link set dev $eth master br0
> ip link set dev $eth up
> done
> ip link set dev br0 type bridge vlan_filtering 1
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists