netdev - Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200527.112515.1714930146142742523.davem@davemloft.net>
Date:   Wed, 27 May 2020 11:25:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brgl@...ev.pl
Cc:     john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        kuba@...nel.org, matthias.bgg@...il.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        fparent@...libre.com, stephane.leprovost@...iatek.com,
        pedro.tsai@...iatek.com, andrew.perepech@...iatek.com,
        bgolaszewski@...libre.com, natechancellor@...il.com
Subject: Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX
 handling

From: Bartosz Golaszewski <brgl@...ev.pl>
Date: Wed, 27 May 2020 11:24:04 +0200

> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> The dma_addr field in desc_data must not be overwritten until after the
> new skb is mapped. Currently we do replace it with uninitialized value
> in error path. This change fixes it by moving the assignment before the
> label to which we jump after mapping or allocation errors.
> 
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Nathan Chancellor <natechancellor@...il.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Applied, please use "[PATCH net-next]" to clearly indicate the target
GIT tree next time.

Thank you.