netdev - Re: [PATCH v2 net-next] net: dsa: sja1105: offload the Credit-Based Shaper qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+h21hpLnZRHX75MXE7utoers2Dcfoz-K60ru5cN_b1+y5zLMg@mail.gmail.com>
Date:   Thu, 28 May 2020 02:30:05 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] net: dsa: sja1105: offload the Credit-Based
 Shaper qdisc

On Thu, 28 May 2020 at 02:28, Vinicius Costa Gomes
<vinicius.gomes@...el.com> wrote:
>
> Vladimir Oltean <olteanv@...il.com> writes:
>
> > From: Vladimir Oltean <vladimir.oltean@....com>
> >
> > SJA1105, being AVB/TSN switches, provide hardware assist for the
> > Credit-Based Shaper as described in the IEEE 8021Q-2018 document.
> >
> > First generation has 10 shapers, freely assignable to any of the 4
> > external ports and 8 traffic classes, and second generation has 16
> > shapers.
> >
> > We also need to provide a dummy implementation of mqprio qdisc offload,
> > since this seems to be necessary for shaping any traffic class other
> > than zero.
>
> This is false, right?
>
>
> Cheers,
> --
> Vinicius

Yes, good catch, I forgot to remove this paragraph from the commit
description. Do I need to send a v3, I wonder?

Thanks,
-Vladimir