netdev - Re: [PATCH 0/9 v2] Remove FMR support from RDMA drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200528010615.GD24561@mellanox.com>
Date:   Wed, 27 May 2020 22:06:15 -0300
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Max Gurtovoy <maxg@...lanox.com>
Cc:     dledford@...hat.com, leon@...nel.org, galpress@...zon.com,
        dennis.dalessandro@...el.com, netdev@...r.kernel.org,
        sagi@...mberg.me, linux-rdma@...r.kernel.org, bvanassche@....org,
        santosh.shilimkar@...cle.com, tom@...pey.com,
        aron.silverton@...cle.com, israelr@...lanox.com, oren@...lanox.com,
        shlomin@...lanox.com, vladimirk@...lanox.com
Subject: Re: [PATCH 0/9 v2] Remove FMR support from RDMA drivers

On Wed, May 27, 2020 at 12:46:25PM +0300, Max Gurtovoy wrote:
> This series removes the support for FMR mode to register memory. This ancient
> mode is unsafe (rkeys that are usually exposed for caching purposes and the API
> is limited to page granularity mappings) and not maintained/tested in the last
> few years. It also doesn't have any reasonable advantage over other memory
> registration methods such as FRWR (that is implemented in all the recent RDMA
> adapters). This series should be reviewed and approved by the maintainer of the
> effected drivers and I suggest to test it as well.
> 
> The tests that I made for this series (fio benchmarks and fio verify data):
> 1. iSER initiator on ConnectX-4
> 2. iSER initiator on ConnectX-3
> 3. SRP initiator on ConnectX-4 (loopback to SRP target)
> 4. SRP initiator on ConnectX-3

I looked at this for a bit, and it seems like there is still a fair
amount more to remove, I came up with this:

https://github.com/jgunthorpe/linux/commits/for_max

Can you check?

Thanks
Jason