lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 28 May 2020 15:57:24 +0200
From:   Bartosz Golaszewski <>
To:     Mark Brown <>
Cc:     John Crispin <>,
        Sean Wang <>,
        Mark Lee <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,
        Matthias Brugger <>,
        netdev <>,
        Linux ARM <>,
        "moderated list:ARM/Mediatek SoC..." 
        Linux Kernel Mailing List <>,
        Fabien Parent <>,
        Stephane Le Provost <>,
        Pedro Tsai <>,
        Andrew Perepech <>,
        Bartosz Golaszewski <>
Subject: Re: [PATCH 1/2] regmap: provide helpers for simple bit operations

czw., 28 maj 2020 o 15:48 Mark Brown <> napisał(a):
> On Thu, May 28, 2020 at 03:32:40PM +0200, Bartosz Golaszewski wrote:
> > czw., 28 maj 2020 o 15:29 Mark Brown <> napisał(a):
> > > Why macros and not static inlines?
> > The existing regmap_update_bits_*() helpers are macros too, so I tried
> > to stay consistent. Any reason why they are macros and not static
> > inlines? If there's none, then why not convert them too? Otherwise
> > we'd have a static inline expanding a macro which in turn is calling a
> > function (regmap_update_bits_base()).
> Not really, I think it was just that they're argument tables.  It'd be
> good to convert them.

Ok. So I'm seeing there are a lot of macros in regmap.h that could
become static inlines but given the amount of regmap users: how about
we do it separately and in the meantime I'll just modify this series
to use static inlines?


Powered by blists - more mailing lists