netdev - Re: [PATCH net-next 02/11] net: mscc: ocelot: unexport ocelot_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200528092112.6892e6b5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 28 May 2020 09:21:12 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        linux@...linux.org.uk, antoine.tenart@...tlin.com,
        alexandre.belloni@...tlin.com, horatiu.vultur@...rochip.com,
        allan.nielsen@...rochip.com, UNGLinuxDriver@...rochip.com,
        alexandru.marginean@....com, claudiu.manoil@....com,
        madalin.bucur@....nxp.com, radu-andrei.bulie@....com,
        fido_max@...ox.ru
Subject: Re: [PATCH net-next 02/11] net: mscc: ocelot: unexport
 ocelot_probe_port

On Thu, 28 May 2020 02:41:04 +0300 Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> This is not being used by any other module except ocelot (i.e. felix
> does not use it). So remove the EXPORT_SYMBOL.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  drivers/net/ethernet/mscc/ocelot.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index e621c4c3ee86..ff875c2f1d46 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -2152,7 +2152,6 @@ int ocelot_probe_port(struct ocelot *ocelot, u8 port,
>  
>  	return err;
>  }
> -EXPORT_SYMBOL(ocelot_probe_port);
>  
>  /* Configure and enable the CPU port module, which is a set of queues.
>   * If @npi contains a valid port index, the CPU port module is connected

Strangely I get an error after this patch:

ERROR: modpost: "ocelot_probe_port"
[drivers/net/ethernet/mscc/ocelot_board.ko] undefined! make[2]: ***
[__modpost] Error 1 make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2

Maybe a build system error, could you double check?