netdev - Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200528121216.16b8ec77@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 28 May 2020 12:12:16 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     rohit maheshwari <rohitm@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com
Subject: Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

On Thu, 28 May 2020 09:36:43 +0530 rohit maheshwari wrote:
> CHCR driver is a ULD driver, and if user requests to remove chcr alone,
> this cleanup will be done. This is why I am taking module refcount until
> tls offload flag is set, or any single tls offload connection exists.  
> So, now,
> when this cleanup will be triggered, TLS offload won't be enabled, and
> this crash situation can never occur.

You expect that if there is no TLS connection and feature flag was
cleared nobody will call tlsdev_ops again. I've shown you in the
previous email that the callers of those ops are not synchronized
against flag changes.