netdev - Re: [PATCH net-next] net/mlx5e: Uninitialized variable in mlx5e_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49b098dad758ba232c1e41a00421daafedc1fda0.camel@mellanox.com>
Date:   Thu, 28 May 2020 20:56:06 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Vlad Buslov <vladbu@...lanox.com>,
        Paul Blakey <paulb@...lanox.com>, Eli Cohen <eli@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "leon@...nel.org" <leon@...nel.org>, Roi Dayan <roid@...lanox.com>
Subject: Re: [PATCH net-next] net/mlx5e: Uninitialized variable in
 mlx5e_attach_decap()

On Thu, 2020-05-28 at 15:48 +0300, Dan Carpenter wrote:
> The "ret" variable isn't initialized on the success path.
> 
> There is an uninitentional behavior in current releases of GCC where
> instead of warning about the uninitialized variable, it instead
> initializes it to zero.  So that means that this bug likely doesn't
> affect testing.
> 
> Fixes: 14e6b038afa0 ("net/mlx5e: Add support for hw decapsulation of
> MPLS over UDP")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Hi Dan,

thanks for the fix,  a similar fix was already submitted yesterday and
i already pulled it into my tree, I will send a pull request to net-
next soon.

Thanks,
Saeed.