lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 29 May 2020 01:21:37 +0200 (CEST)
From:   Michal Kubecek <>
To:     John Linville <>,
Cc:     Andrew Lunn <>,
        Oleksij Rempel <>
Subject: [PATCH ethtool 06/21] selftest: omit test-features if netlink is

The test-features selftest is checking data structures passed to ioctl()
syscall. Therefore a complete rework of the test framework will be needed
to be able to perform an equivalent selftest for netlink interface. Until
such framework is implemented, disable test-features when building ethtool
with netlink support.

Signed-off-by: Michal Kubecek <>
--- | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/ b/
index 0f8465f7ada9..b3ffae52f1e9 100644
--- a/
+++ b/
@@ -40,12 +40,16 @@ AM_CPPFLAGS += @MNL_CFLAGS@
-TESTS = test-cmdline test-features
-check_PROGRAMS = test-cmdline test-features
+TESTS = test-cmdline
+check_PROGRAMS = test-cmdline
 test_cmdline_SOURCES = test-cmdline.c test-common.c $(ethtool_SOURCES) 
 test_cmdline_CFLAGS = -DTEST_ETHTOOL
+TESTS += test-features
+check_PROGRAMS += test-features
 test_features_SOURCES = test-features.c test-common.c $(ethtool_SOURCES) 
 test_features_CFLAGS = -DTEST_ETHTOOL
 	cp $(top_srcdir)/ethtool.spec $(distdir)

Powered by blists - more mailing lists