lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 May 2020 10:22:56 +0200 From: Jesper Dangaard Brouer <brouer@...hat.com> To: David Ahern <dsahern@...nel.org> Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, toke@...hat.com, lorenzo@...nel.org, daniel@...earbox.net, john.fastabend@...il.com, ast@...nel.org, kafai@...com, songliubraving@...com, yhs@...com, andriin@...com, dsahern@...il.com, brouer@...hat.com Subject: Re: [PATCH v3 bpf-next 1/5] devmap: Formalize map value as a named struct On Thu, 28 May 2020 23:20:53 -0600 David Ahern <dsahern@...nel.org> wrote: > Add 'struct bpf_devmap_val' to the bpf uapi to formalize the > expected values that can be passed in for a DEVMAP. > Update devmap code to use the struct. > > Signed-off-by: David Ahern <dsahern@...nel.org> > --- > include/uapi/linux/bpf.h | 5 +++++ > kernel/bpf/devmap.c | 40 +++++++++++++++++++--------------- > tools/include/uapi/linux/bpf.h | 5 +++++ > 3 files changed, 33 insertions(+), 17 deletions(-) > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 54b93f8b49b8..42c884dfbad9 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -3625,6 +3625,11 @@ struct xdp_md { > __u32 rx_queue_index; /* rxq->queue_index */ > }; > > +/* DEVMAP values */ > +struct bpf_devmap_val { > + __u32 ifindex; /* device index */ > +}; We do need this struct bpf_devmap_val, but I think it is wrong to make this UAPI. A BPF-prog can get this via: #include "vmlinux.h" -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
Powered by blists - more mailing lists