lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 May 2020 12:22:55 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Yi Wang <wang.yi59@....com.cn> Cc: davem@...emloft.net, kuba@...nel.org, mst@...hat.com, hkallweit1@...il.com, snelson@...sando.io, xiyou.wangcong@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, xue.zhihong@....com.cn, wang.liang82@....com.cn, Liao Pingfang <liao.pingfang@....com.cn> Subject: Re: [PATCH] net: atm: Replace kmalloc with kzalloc in the error message On Fri, May 29, 2020 at 09:01:42AM +0800, Yi Wang wrote: > From: Liao Pingfang <liao.pingfang@....com.cn> > > Use kzalloc instead of kmalloc in the error message according to > the previous kzalloc() call. Looking into the context (atomic!) and error message itself I would rather drop message completely. > Signed-off-by: Liao Pingfang <liao.pingfang@....com.cn> > --- > net/atm/lec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/atm/lec.c b/net/atm/lec.c > index ca37f5a..33033d7 100644 > --- a/net/atm/lec.c > +++ b/net/atm/lec.c > @@ -1537,7 +1537,7 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv, > > to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC); > if (!to_return) { > - pr_info("LEC: Arp entry kmalloc failed\n"); > + pr_info("LEC: Arp entry kzalloc failed\n"); > return NULL; > } > ether_addr_copy(to_return->mac_addr, mac_addr); > -- > 2.9.5 > -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists