netdev - Re: [PATCH net-next] net: phy: mscc: fix PHYs using the vsc8574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <223CE44E-8ACF-4F31-B5EC-FA5468F9D54A@walle.cc>
Date:   Fri, 29 May 2020 13:11:00 +0200
From:   Michael Walle <michael@...le.cc>
To:     Antoine Tenart <antoine.tenart@...tlin.com>, davem@...emloft.net,
        andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com
CC:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: mscc: fix PHYs using the vsc8574_probe

Am 29. Mai 2020 11:49:09 MESZ schrieb Antoine Tenart <antoine.tenart@...tlin.com>:
>PHYs using the vsc8574_probe fail to be initialized and their
>config_init return -EIO leading to errors like:
>"could not attach PHY: -5".
>
>This is because when the conversion of the MSCC PHY driver to use the
>shared PHY package helpers was done, the base address retrieval and the
>base PHY read and write helpers in the driver were modified. In
>particular, the base address retrieval logic was moved from the
>config_init to the probe. But the vsc8574_probe was forgotten. This
>patch fixes it.
>
>Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared")
>Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Reviewed-by: Michael Walle <michael@...le.cc>

thanks, 
-michael