netdev - Re: [PATCH] net: udp: remove the redundant assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f88a32fd6bdc9e4279cf673966be203bae4652e1.camel@perches.com>
Date:   Fri, 29 May 2020 04:32:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     Wang Li <wangli8850@...il.com>, netdev@...r.kernel.org
Cc:     Wang Li <wangli09@...ishou.com>
Subject: Re: [PATCH] net: udp: remove the redundant assignment

On Fri, 2020-05-29 at 19:23 +0800, Wang Li wrote:
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
[]
> @@ -798,7 +798,6 @@ void udp_set_csum(bool nocheck, struct sk_buff *skb,
>  	} else if (skb_is_gso(skb)) {
>  		uh->check = ~udp_v4_check(len, saddr, daddr, 0);
>  	} else if (skb->ip_summed == CHECKSUM_PARTIAL) {
> -		uh->check = 0;
>  		uh->check = udp_v4_check(len, saddr, daddr, lco_csum(skb));

Why do you think this is redundant?

Where does uh point? (struct udphdr *uh = udp_hdr(skb);)
What is lco_csum(skb) doing?