lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 29 May 2020 11:12:11 -0700
From:   Eric Dumazet <>
To:     "David S . Miller" <>
Cc:     netdev <>,
        Eric Dumazet <>,
        James Chapman <>,
        Andrii Nakryiko <>,
Subject: Re: [PATCH net] l2tp: do not use inet_hash()/inet_unhash()

On Fri, May 29, 2020 at 11:08 AM Eric Dumazet <> wrote:
> syzbot recently found a way to crash the kernel [1]
> Issue here is that inet_hash() & inet_unhash() are currently
> only meant to be used by TCP & DCCP, since only these protocols
> provide the needed hashinfo pointer.
> L2TP uses a single list (instead of a hash table)
> This old bug became an issue after commit 610236587600
> ("bpf: Add new cgroup attach type to enable sock modifications")
> since after this commit, sk_common_release() can be called
> while the L2TP socket is still considered 'hashed'.

> Fixes: 0d76751fad77 ("l2tp: Add L2TPv3 IP encapsulation (no UDP) support")
> Signed-off-by: Eric Dumazet <>
> Cc: James Chapman <>
> Cc: Andrii Nakryiko <>
> Reported-by:
> ---

Will send a V2, I missed that ip and ipv6 modules were using a different rwlock.

Powered by blists - more mailing lists