netdev - Re: [net 3/6] net/mlx5e: Remove warning "devices are not on same switch HW"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 May 2020 20:00:06 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     Roi Dayan <roid@...lanox.com>, Maor Dickman <maord@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net 3/6] net/mlx5e: Remove warning "devices are not on same
 switch HW"

On Fri, 2020-05-29 at 12:12 -0700, Jakub Kicinski wrote:
> On Thu, 28 May 2020 23:56:42 -0700 Saeed Mahameed wrote:
> > From: Maor Dickman <maord@...lanox.com>
> > 
> > On tunnel decap rule insertion, the indirect mechanism will attempt
> > to
> > offload the rule on all uplink representors which will trigger the
> > "devices are not on same switch HW, can't offload forwarding"
> > message
> > for the uplink which isn't on the same switch HW as the VF
> > representor.
> > 
> > The above flow is valid and shouldn't cause warning message,
> > fix by removing the warning and only report this flow using extack.
> > 
> > Fixes: f3953003a66f ("net/mlx5e: Fix allowed tc redirect merged
> > eswitch offload cases")
> > Signed-off-by: Maor Dickman <maord@...lanox.com>
> > Reviewed-by: Roi Dayan <roid@...lanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> 
> Fixes tag: Fixes: f3953003a66f ("net/mlx5e: Fix allowed tc redirect
> merged eswitch offload cases")
> Has these problem(s):
> 	- Target SHA1 does not exist

Fixing, thanks !