netdev - RE: [PATCH net-next v3 2/7] dpaa2-eth: Distribute ingress frames based on VLAN prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB38715BFD2DAB1A70B1F0F6B8E08F0@VI1PR0402MB3871.eurprd04.prod.outlook.com>
Date:   Fri, 29 May 2020 22:20:47 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH net-next v3 2/7] dpaa2-eth: Distribute ingress frames
 based on VLAN prio

> Subject: Re: [PATCH net-next v3 2/7] dpaa2-eth: Distribute ingress frames based
> on VLAN prio
> 
> On Fri, 29 May 2020 21:41:38 +0000 Ioana Ciornei wrote:
> > > Subject: Re: [PATCH net-next v3 2/7] dpaa2-eth: Distribute ingress
> > > frames based on VLAN prio
> > >
> > > On Fri, 29 May 2020 20:43:40 +0300 Ioana Ciornei wrote:
> > > > From: Ioana Radulescu <ruxandra.radulescu@....com>
> > > >
> > > > Configure static ingress classification based on VLAN PCP field.
> > > > If the DPNI doesn't have enough traffic classes to accommodate all
> > > > priority levels, the lowest ones end up on TC 0 (default on miss).
> > > >
> > > > Signed-off-by: Ioana Radulescu <ruxandra.radulescu@....com>
> > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> > > > ---
> > > > Changes in v3:
> > > >  - revert to explicitly cast mask to u16 * to not get into
> > > >    sparse warnings
> > >
> > > Doesn't seem to have worked:
> > >
> > > ../drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2761:22: warning:
> > > incorrect type in assignment (different base types)
> > > ../drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2761:22:    expected
> > > unsigned short [usertype]
> > > ../drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2761:22:    got
> restricted
> > > __be16 [usertype]
> > > ../drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2780:29: warning:
> > > incorrect type in assignment (different base types)
> > > ../drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2780:29:    expected
> > > unsigned short [usertype]
> > > ../drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2780:29:    got
> restricted
> > > __be16 [usertype]
> >
> > I don't' know what I am missing but I am not seeing these.
> 
> $ sparse --version
> 0.6.1
> $ gcc --version
> gcc (GCC) 10.0.1 20200504 (prerelease)
> 
> Build with W=1 C=1

Thanks, after an update of sparse I got these.

Fixed locally but I think it's better to wait maybe until my next morning to send a new version.. maybe there is any other feedback that's needs to be addressed.

Ioana