netdev - Re: [PATCH net] neigh: fix ARP retransmit timer guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200529.165747.1274640204927282377.davem@davemloft.net>
Date:   Fri, 29 May 2020 16:57:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, jiji@...hat.com
Subject: Re: [PATCH net] neigh: fix ARP retransmit timer guard

From: Hangbin Liu <liuhangbin@...il.com>
Date: Thu, 28 May 2020 15:15:13 +0800

> In commit 19e16d220f0a ("neigh: support smaller retrans_time settting")
> we add more accurate control for ARP and NS. But for ARP I forgot to
> update the latest guard in neigh_timer_handler(), then the next
> retransmit would be reset to jiffies + HZ/2 if we set the retrans_time
> less than 500ms. Fix it by setting the time_before() check to HZ/100.
> 
> IPv6 does not have this issue.
> 
> Reported-by: Jianwen Ji <jiji@...hat.com>
> Fixes: 19e16d220f0a ("neigh: support smaller retrans_time settting")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Applied, thank you.