netdev - Re: [PATCH] net: ethtool: cabletest: Make ethnl_act_cable_test_tdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 May 2020 17:30:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, lkp@...el.com
Subject: Re: [PATCH] net: ethtool: cabletest: Make
 ethnl_act_cable_test_tdr_cfg static

From: Andrew Lunn <andrew@...n.ch>
Date: Thu, 28 May 2020 23:43:24 +0200

> kbuild test robot is reporting:
> net/ethtool/cabletest.c:230:5: warning: no previous prototype for
> 
> Mark the function as static.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks Andrew.  Please put "net-next" or similar next time.

Also, a Fixes: tag would have been nice but I won't require it for
something like this.

Hmmm, I also just noticed how onerous that PHYLINK=y/n requirement
is for the ethtool netlink stuff :-/