netdev - Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200530022022.GI877847@lunn.ch>
Date:   Sat, 30 May 2020 04:20:22 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vadym Kochan <vadym.kochan@...ision.eu>
Cc:     David Miller <davem@...emloft.net>, kuba@...nel.org,
        jiri@...lanox.com, idosch@...lanox.com,
        oleksandr.mazur@...ision.eu, serhiy.boiko@...ision.eu,
        serhiy.pshyk@...ision.eu, volodymyr.mytnyk@...ision.eu,
        taras.chornyi@...ision.eu, andrii.savka@...ision.eu,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        mickeyr@...vell.com
Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera
 family ASIC devices

On Sat, May 30, 2020 at 03:46:22AM +0300, Vadym Kochan wrote:
> Hi David,
> 
> On Fri, May 29, 2020 at 05:18:39PM -0700, David Miller wrote:
> > 
> > Please remove all of the __packed attributes.
> > 
> > I looked at your data structures and all of them use fixed sized types
> > and are multiples of 4 so the __packed attribute is completely
> > unnecessary.
> > 
> > The alignment attribute is also unnecessary so please remove that too.
> 
> Some of the fields are u8, so I assume there might be holes added by
> the compiler ? Also these attributes guarantee some ABI compatibility
> with FW side, I will try to remove them and check but it sounds for me a bit
> risky.

Hi Vadym

You might want to play with pahole(1).

    Andrew