lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 May 2020 14:41:07 +0200 From: Petr Vaněk <pv@...ello.cz> To: Christophe Gouault <christophe.gouault@...nd.com> Cc: Steffen Klassert <steffen.klassert@...unet.com>, Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] xfrm: no-anti-replay protection flag Hi Christophe, On Wed, May 27, 2020 at 07:11:21PM +0200, Christophe Gouault wrote: > This patch is useful, however I think you should change the name of > the option and amend its description: > the option does not disable anti-replay in output (it can only be > disabled in input), it allows the output sequence number to wrap, and > it assumes that the remote peer disabled anti-replay in input. > > So you I suggest you change the name of the option to something like > XFRM_SA_XFLAG_OSEQ_MAY_WRAP or XFRM_SA_XFLAG_ALLOW_OSEQ_WRAP. thank you for your suggestions, I changed the patch and sent the second version. Petr
Powered by blists - more mailing lists