lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 May 2020 16:34:30 +0300 From: Ido Schimmel <idosch@...sch.org> To: Roopa Prabhu <roopa@...ulusnetworks.com> Cc: davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org, dsahern@...il.com, nikolay@...ulusnetworks.com, jiri@...lanox.com, idosch@...lanox.com, petrm@...lanox.com Subject: Re: [PATCH net-next 0/2] vxlan fdb nexthop misc fixes On Thu, May 28, 2020 at 10:12:34PM -0700, Roopa Prabhu wrote: > From: Roopa Prabhu <roopa@...ulusnetworks.com> Hi Roopa, I noticed that sparse complains about the following problem in the original submission (not handled by current set): drivers/net/vxlan.c:884:41: warning: dereference of noderef expression Seems to be fixed by: diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 39bc10a7fd2e..ea7af03e0957 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -881,13 +881,13 @@ static int vxlan_fdb_nh_update(struct vxlan_dev *vxlan, struct vxlan_fdb *fdb, goto err_inval; } - if (!nh->is_group || !nh->nh_grp->mpath) { + nhg = rtnl_dereference(nh->nh_grp); + if (!nh->is_group || !nhg->mpath) { NL_SET_ERR_MSG(extack, "Nexthop is not a multipath group"); goto err_inval; } /* check nexthop group family */ - nhg = rtnl_dereference(nh->nh_grp); switch (vxlan->default_dst.remote_ip.sa.sa_family) { case AF_INET: if (!nhg->has_v4) { Assuming it's correct, can you please fold it into v2? > > Roopa Prabhu (2): > vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID > vxlan: few locking fixes in nexthop event handler > > drivers/net/vxlan.c | 36 +++++++++++++++++++++++++++++------- > 1 file changed, 29 insertions(+), 7 deletions(-) > > -- > 2.1.4 >
Powered by blists - more mailing lists