netdev - Re: [PATCH v2 1/2] iproute2: ip addr: Organize flag properties structurally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <467c2970-e986-67af-2d19-371b19f8bfbf@gmail.com>
Date:   Sun, 31 May 2020 17:09:07 -0600
From:   David Ahern <dsahern@...il.com>
To:     "Ian K. Coolidge" <icoolidge@...gle.com>, netdev@...r.kernel.org
Cc:     ek@...gle.com
Subject: Re: [PATCH v2 1/2] iproute2: ip addr: Organize flag properties
 structurally

On 5/27/20 12:03 PM, Ian K. Coolidge wrote:
> This creates a nice systematic way to check that the various flags are
> mutable from userspace and that the address family is valid.
> 
> Mutability properties are preserved to avoid introducing any behavioral
> change in this CL. However, previously, immutable flags were ignored and
> fell through to this confusing error:
> 
> Error: either "local" is duplicate, or "dadfailed" is a garbage.
> 
> But now, they just warn more explicitly:
> 
> Warning: dadfailed option is not mutable from userspace
> ---
>  ip/ipaddress.c | 112 ++++++++++++++++++++++++-------------------------
>  1 file changed, 55 insertions(+), 57 deletions(-)
> 

applied both to iproute2-next. Thanks,