[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20200530.214337.1492575923118562439.davem@davemloft.net>
Date: Sat, 30 May 2020 21:43:37 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: clew@...eaurora.org
Cc: bjorn.andersson@...aro.org, manivannan.sadhasivam@...aro.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] net: qrtr: Allocate workqueue before kernel_bind
From: Chris Lew <clew@...eaurora.org>
Date: Thu, 28 May 2020 16:05:26 -0700
> A null pointer dereference in qrtr_ns_data_ready() is seen if a client
> opens a qrtr socket before qrtr_ns_init() can bind to the control port.
> When the control port is bound, the ENETRESET error will be broadcasted
> and clients will close their sockets. This results in DEL_CLIENT
> packets being sent to the ns and qrtr_ns_data_ready() being called
> without the workqueue being allocated.
>
> Allocate the workqueue before setting sk_data_ready and binding to the
> control port. This ensures that the work and workqueue structs are
> allocated and initialized before qrtr_ns_data_ready can be called.
>
> Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace")
> Signed-off-by: Chris Lew <clew@...eaurora.org>
Applied, thank you.
Powered by blists - more mailing lists