lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 May 2020 21:48:41 -0700 From: Roopa Prabhu <roopa@...ulusnetworks.com> To: davem@...emloft.net, kuba@...nel.org Cc: netdev@...r.kernel.org, dsahern@...il.com, nikolay@...ulusnetworks.com, jiri@...lanox.com, idosch@...lanox.com, petrm@...lanox.com Subject: [PATCH net-next v2 3/3] vxlan: fix dereference of nexthop group in nexthop update path From: Roopa Prabhu <roopa@...ulusnetworks.com> fix dereference of nexthop group in fdb nexthop group update validation path. Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries") Reported-by: Ido Schimmel <idosch@...sch.org> Suggested-by: Ido Schimmel <idosch@...sch.org> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com> --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 39bc10a..ea7af03 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -881,13 +881,13 @@ static int vxlan_fdb_nh_update(struct vxlan_dev *vxlan, struct vxlan_fdb *fdb, goto err_inval; } - if (!nh->is_group || !nh->nh_grp->mpath) { + nhg = rtnl_dereference(nh->nh_grp); + if (!nh->is_group || !nhg->mpath) { NL_SET_ERR_MSG(extack, "Nexthop is not a multipath group"); goto err_inval; } /* check nexthop group family */ - nhg = rtnl_dereference(nh->nh_grp); switch (vxlan->default_dst.remote_ip.sa.sa_family) { case AF_INET: if (!nhg->has_v4) { -- 2.1.4
Powered by blists - more mailing lists