netdev - Re: [PATCH net-next 0/2] selftests: forwarding: Two small changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200530.214905.594964732844168436.davem@davemloft.net>
Date:   Sat, 30 May 2020 21:49:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     petrm@...lanox.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net-next 0/2] selftests: forwarding: Two small changes

From: Petr Machata <petrm@...lanox.com>
Date: Fri, 29 May 2020 14:16:52 +0300

> Two unrelated changes in this patchset:
> 
> - In patch #1, convert mirror tests from using ping directly to generating
>   ICMP packets by mausezahn. Using ping in tests is error-prone, because
>   ping is too smart. On a flaky system (notably in a simulator), when
>   packets don't come quickly enough, more pings are sent, and that throws
>   off counters. This was worked around in the past by just pinging more
>   slowly, but using mausezahn avoids the issue as well without making the
>   tests unnecessary slow.
> 
> - A missing stats_update callback was recently added to act_pedit. Now that
>   iproute2 supports JSON dumping for pedit, extend in patch #2 the
>   pedit_dsfield selftest with a check that would have caught the fact that
>   the callback was missing.

Series applied, thanks.