netdev - Re: [PATCH net-next] mptcp: fix NULL ptr dereference in MP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200530.215415.180552611360986513.davem@davemloft.net>
Date:   Sat, 30 May 2020 21:54:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        mptcp@...ts.01.org
Subject: Re: [PATCH net-next] mptcp: fix NULL ptr dereference in MP_JOIN
 error path

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri, 29 May 2020 17:49:18 +0200

> When token lookup on MP_JOIN 3rd ack fails, the server
> socket closes with a reset the incoming child. Such socket
> has the 'is_mptcp' flag set, but no msk socket associated
> - due to the failed lookup.
> 
> While crafting the reset packet mptcp_established_options_mp()
> will try to dereference the child's master socket, causing
> a NULL ptr dereference.
> 
> This change addresses the issue with explicit fallback to
> TCP in such error path.
> 
> Fixes: 729cd6436f35 ("mptcp: cope better with MP_JOIN failure")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thank you.