netdev - Re: [PATCH net] l2tp: add sk_family checks to l2tp_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200530.215747.1590223834792811961.davem@davemloft.net>
Date:   Sat, 30 May 2020 21:57:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        jchapman@...alix.com, gnault@...hat.com, syzkaller@...glegroups.com
Subject: Re: [PATCH net] l2tp: add sk_family checks to l2tp_validate_socket

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 29 May 2020 11:32:25 -0700

> syzbot was able to trigger a crash after using an ISDN socket
> and fool l2tp.
> 
> Fix this by making sure the UDP socket is of the proper family.
 ...
> Fixes: 6b9f34239b00 ("l2tp: fix races in tunnel creation")
> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: James Chapman <jchapman@...alix.com>
> Cc: Guillaume Nault <gnault@...hat.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks.