lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 May 2020 22:17:17 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Heiner Kallweit <hkallweit1@...il.com> Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 1/6] r8169: change driver data type On Sat, 30 May 2020 23:54:36 +0200 Heiner Kallweit <hkallweit1@...il.com> wrote: > Change driver private data type to struct rtl8169_private * to avoid > some overhead. > > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com> > --- Are you sure about this. Using netdev_priv() is actually at a fixed offset from netdev, and almost always the compiler can optimize and use one register. Look at the assembly code difference of what you did.
Powered by blists - more mailing lists