netdev - RE: [PATCH v2] e1000: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB2890EDBB6B1BE7705DF2AB3CBC8A0@DM6PR11MB2890.namprd11.prod.outlook.com>
Date:   Mon, 1 Jun 2020 17:15:54 +0000
From:   "Brown, Aaron F" <aaron.f.brown@...el.com>
To:     Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "bjorn@...gaas.com" <bjorn@...gaas.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>
CC:     "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kernel-mentees@...ts.linuxfoundation.org" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>
Subject: RE: [PATCH v2] e1000: use generic power management

> From: Vaibhav Gupta <vaibhavgupta40@...il.com>
> Sent: Monday, May 25, 2020 5:27 AM
> To: Vaibhav Gupta <vaibhav.varodek@...il.com>; Bjorn Helgaas
> <helgaas@...nel.org>; Bjorn Helgaas <bhelgaas@...gle.com>;
> bjorn@...gaas.com; Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; David S.
> Miller <davem@...emloft.net>; rjw@...ysocki.net
> Cc: Vaibhav Gupta <vaibhavgupta40@...il.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; intel-wired-lan@...ts.osuosl.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-kernel-
> mentees@...ts.linuxfoundation.org; skhan@...uxfoundation.org
> Subject: [PATCH v2] e1000: use generic power management
> 
> compile-tested only
> 
> With legacy PM hooks, it was the responsibility of a driver to manage PCI
> states and also the device's power state. The generic approach is to let PCI
> core handle the work.
> 
> e1000_suspend() calls __e1000_shutdown() to perform intermediate tasks.
> __e1000_shutdown() modifies the value of "wake" (device should be wakeup
> enabled or not), responsible for controlling the flow of legacy PM.
> 
> Since, PCI core has no idea about the value of "wake", new code for generic
> PM may produce unexpected results. Thus, use "device_set_wakeup_enable()"
> to wakeup-enable the device accordingly.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c | 49 +++++--------------
>  1 file changed, 13 insertions(+), 36 deletions(-)

I don't have many old PCI systems that handle power management properly before adding this patch.  However, the few ones that do continue to do so with the older e1000 parts I still have around.  So a small sample, but at least confirmed on _some_ real hardware
Tested-by: Aaron Brown <aaron.f.brown@...el.com>