netdev - Re: [PATCH net-next v5] hinic: add set_channels ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 01 Jun 2020 10:53:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     luobin9@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        luoxianjun@...wei.com, yin.yinshi@...wei.com,
        cloud.wangxiaoyun@...wei.com
Subject: Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support

From: Luo bin <luobin9@...wei.com>
Date: Mon, 1 Jun 2020 18:57:48 +0800

> @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
>  	struct hinic_txq *txq;
>  	struct hinic_qp *qp;
>  
> +	if (unlikely(!netif_carrier_ok(netdev))) {
> +		dev_kfree_skb_any(skb);
> +		return NETDEV_TX_OK;
> +	}

As stated by another reviewer, this change is unrelated to adding
set_channels support.  Please remove it from this patch.