netdev - Re: [PATCH net-next] cxgb4: cleanup error code in setup_sge_queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200601.113351.412390872566987442.davem@davemloft.net>
Date:   Mon, 01 Jun 2020 11:33:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     vishal@...lsio.com, kuba@...nel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] cxgb4: cleanup error code in
 setup_sge_queues_uld()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 28 May 2020 15:49:57 +0300

> The caller doesn't care about the error codes, they only check for zero
> vs non-zero.  Still, it's better to preserve the negative error codes
> from alloc_uld_rxqs() instead of changing it to 1.  We can also return
> directly if there is a failure.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.