netdev - Re: [bpf-next PATCH 2/3] bpf: fix running sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+2NTdyKY+ZX3xW965h8_PGRimy9se=iqW6AvmnB8v7wg@mail.gmail.com>
Date:   Mon, 1 Jun 2020 14:23:25 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Jakub Sitnicki <jakub@...udflare.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [bpf-next PATCH 2/3] bpf: fix running sk_skb program types with ktls

On Mon, Jun 1, 2020 at 8:20 AM John Fastabend <john.fastabend@...il.com> wrote:
> > > @@ -1793,11 +1795,12 @@ int tls_sw_recvmsg(struct sock *sk,
> > >
> > >             if (to_decrypt <= len && !is_kvec && !is_peek &&
> > >                 ctx->control == TLS_RECORD_TYPE_DATA &&
> > > -               prot->version != TLS_1_3_VERSION)
> > > +               prot->version != TLS_1_3_VERSION &&
> > > +               !sk_psock_strp_enabled(psock))
> >
> > Is this recheck of parser state intentional? Or can we test for
> > "!bpf_strp_enabled" here also?
>
> Yes I'll fix it up to use bpf_strp_enabled. Thanks

I fixed that bit and applied the set.

Thanks!