netdev - Re: [PATCH v4 11/11] thermal: Rename set_mode() to change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49000a709ad0fd5c86005d43f776a8f4@piie.net>
Date:   Mon, 01 Jun 2020 11:38:44 +0000
From:   "Peter Kästle" <peter@...e.net>
To:     "Andrzej Pietrasiewicz" <andrzej.p@...labora.com>,
        linux-pm@...r.kernel.org, linux-acpi@...r.kernel.org,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org,
        linux-rockchip@...ts.infradead.org
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        "Len Brown" <lenb@...nel.org>,
        "Vishal Kulkarni" <vishal@...lsio.com>,
        "David S . Miller" <davem@...emloft.net>,
        "Jiri Pirko" <jiri@...lanox.com>,
        "Ido Schimmel" <idosch@...lanox.com>,
        "Johannes Berg" <johannes.berg@...el.com>,
        "Emmanuel Grumbach" <emmanuel.grumbach@...el.com>,
        "Luca Coelho" <luciano.coelho@...el.com>,
        "Intel Linux Wireless" <linuxwifi@...el.com>,
        "Kalle Valo" <kvalo@...eaurora.org>,
        "Darren Hart" <dvhart@...radead.org>,
        "Andy Shevchenko" <andy@...radead.org>,
        "Sebastian Reichel" <sre@...nel.org>,
        "Miquel Raynal" <miquel.raynal@...tlin.com>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        "Amit Kucheria" <amit.kucheria@...durent.com>,
        "Support Opensource" <support.opensource@...semi.com>,
        "Shawn Guo" <shawnguo@...nel.org>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "Fabio Estevam" <festevam@...il.com>,
        "NXP Linux Team" <linux-imx@....com>,
        "Niklas Söderlund" 
        <niklas.soderlund@...natech.se>,
        "Heiko Stuebner" <heiko@...ech.de>,
        "Orson Zhai" <orsonzhai@...il.com>,
        "Baolin Wang" <baolin.wang7@...il.com>,
        "Chunyan Zhang" <zhang.lyra@...il.com>,
        "Zhang Rui" <rui.zhang@...el.com>,
        "Allison Randal" <allison@...utok.net>,
        "Enrico Weigelt" <info@...ux.net>,
        "Gayatri Kammela" <gayatri.kammela@...el.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Bartlomiej Zolnierkiewicz" <b.zolnierkie@...sung.com>,
        kernel@...labora.com
Subject: Re: [PATCH v4 11/11] thermal: Rename set_mode() to change_mode()

28. Mai 2020 21:22, "Andrzej Pietrasiewicz" <andrzej.p@...labora.com> schrieb:

> set_mode() is only called when tzd's mode is about to change. Actual
> setting is performed in thermal_core, in thermal_zone_device_set_mode().
> The meaning of set_mode() callback is actually to notify the driver about
> the mode being changed and giving the driver a chance to oppose such
> change.
> 
> To better reflect the purpose of the method rename it to change_mode()
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
> ---
> drivers/platform/x86/acerhdf.c | 6 +++---

Acked-by: Peter Kaestle <peter@...e.net>