netdev - 答复: [PATCH] i40e: fix wrong index in i40e_xsk_umem_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <562a0ea8fe694d5c82dba6f446d1b518@baidu.com>
Date:   Tue, 2 Jun 2020 12:10:18 +0000
From:   "Li,Rongqing" <lirongqing@...du.com>
To:     Björn Töpel <bjorn.topel@...il.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        Netdev <netdev@...r.kernel.org>
CC:     bpf <bpf@...r.kernel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: 答复: [PATCH] i40e: fix wrong index in i40e_xsk_umem_dma_map



> -----邮件原件-----
> 发件人: Björn Töpel [mailto:bjorn.topel@...il.com]
> 发送时间: 2020年6月2日 19:27
> 收件人: Li,Rongqing <lirongqing@...du.com>; intel-wired-lan
> <intel-wired-lan@...ts.osuosl.org>; Netdev <netdev@...r.kernel.org>
> 抄送: bpf <bpf@...r.kernel.org>; Karlsson, Magnus
> <magnus.karlsson@...el.com>
> 主题: Re: [PATCH] i40e: fix wrong index in i40e_xsk_umem_dma_map
> 
> On Tue, 2 Jun 2020 at 11:20, Li RongQing <lirongqing@...du.com> wrote:
> >
> 
> Li, thanks for the patch! Good catch!
> 
> Please add a proper description for the patch. The fix should be added to the
> stable branches (5.7 and earlier). Note that this code was recently removed in
> favor of the new AF_XDP buffer allocation scheme.
> 
> 

Ok

-LiRongQing 

> Björn
> 
> > Fixes: 0a714186d3c0 "(i40e: add AF_XDP zero-copy Rx support)"
> > Signed-off-by: Li RongQing <lirongqing@...du.com>
> > ---
> >  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> > b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> > index 0b7d29192b2c..c926438118ea 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> > @@ -37,9 +37,9 @@ static int i40e_xsk_umem_dma_map(struct i40e_vsi
> > *vsi, struct xdp_umem *umem)
> >
> >  out_unmap:
> >         for (j = 0; j < i; j++) {
> > -               dma_unmap_page_attrs(dev, umem->pages[i].dma,
> PAGE_SIZE,
> > +               dma_unmap_page_attrs(dev, umem->pages[j].dma,
> > + PAGE_SIZE,
> >                                      DMA_BIDIRECTIONAL,
> I40E_RX_DMA_ATTR);
> > -               umem->pages[i].dma = 0;
> > +               umem->pages[j].dma = 0;
> >         }
> >
> >         return -1;
> > --
> > 2.16.2
> >