netdev - Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c58e2276-81a1-5d4a-b6e1-b89fe076e8ba@mellanox.com>
Date:   Tue, 2 Jun 2020 07:23:53 +0300
From:   Boris Pismenny <borisp@...lanox.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

On 02/06/2020 1:12, Jakub Kicinski wrote:
> On Sun, 31 May 2020 15:06:28 +0300 Boris Pismenny wrote:
>> On 30/05/2020 0:50, Jakub Kicinski wrote:
>>
>>> IIUC every ooo packet causes a resync request in your
>>> implementation - is that true?
>>>   
>> No, only header loss. We never required a resync per OOO packet. I'm
>> not sure why would you think that.
> I mean until device is back in sync every frame kicks off
> resync_update_sn() and tries to queue the work, right?
>
Nope, only the first frame triggers resync_update_sn, so as to keep the process efficient and avoid spamming the system with resync requests. Per-flow, the device will try again to trigger resync_update_sn only if it gets out of sync due to out-of-sequence record headers.