netdev - Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200602112703.13166ffa@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 2 Jun 2020 11:27:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Boris Pismenny <borisp@...lanox.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

On Tue, 2 Jun 2020 07:23:53 +0300 Boris Pismenny wrote:
> On 02/06/2020 1:12, Jakub Kicinski wrote:
> > On Sun, 31 May 2020 15:06:28 +0300 Boris Pismenny wrote:  
> >> On 30/05/2020 0:50, Jakub Kicinski wrote:
> >>  
> >>> IIUC every ooo packet causes a resync request in your
> >>> implementation - is that true?
> >>>     
> >> No, only header loss. We never required a resync per OOO packet. I'm
> >> not sure why would you think that.  
> > I mean until device is back in sync every frame kicks off
> > resync_update_sn() and tries to queue the work, right?
> >  
> Nope, only the first frame triggers resync_update_sn, so as to keep
> the process efficient and avoid spamming the system with resync
> requests. Per-flow, the device will try again to trigger
> resync_update_sn only if it gets out of sync due to out-of-sequence
> record headers.

It'd be good to clarify what the ooo counter counts in the
documentation, it sounds like it counts first TLS header HW found 
after seq discontinuity is detected?

In fact calling this a ooo counter may be slightly misleading, I like
the nfp counters much more: tx_tls_resync_req_ok and
tx_tls_resync_req_ign.